[Bug 545046] Review Request: CVector - ANSI C API for Dynamic Arrays

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545046


Takanori MATSUURA <t.matsuu at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: cvector -   |Review Request: CVector -
                   |ANSI C API for Dynamic      |ANSI C API for Dynamic
                   |Arrays                      |Arrays




--- Comment #2 from Takanori MATSUURA <t.matsuu at gmail.com>  2009-12-08 09:19:22 EDT ---
Spec URL: http://t-matsuu.sakura.ne.jp/mock/CVector.spec
SRPM URL:
http://t-matsuu.sakura.ne.jp/mock/CVector-1.0.3-2.20090805.fc12.src.rpm

Update based on the comment for another in-parallel reviewing package.

* Rename to CVector to keep upstream package name.
* Move static library to separated subpackage.


Thank you for reviewing, Jussi.

(In reply to comment #1)
> - you should have a comment about the necessity of the patch in the spec file,
> for example
>  # Make install target libdir multilib compatible
>  Patch0: cvector-1.0.3-libdir.patch
> I'm not sure why you change the libtool commands. Can you please clarify what
> is the intent of adding --tag=CC?

"--tag=" is now removed because it's not needed for Fedora package.
Other fix is for changing destination directories and implement as a command at
the beginning of %build.  Therefore the patch is removed now.


> - You have misspelled "vector" as "vecrot" in the %description of -devel.

Fixed.  Thanks.


> - Send the Makefile patch upstream. The makefile also lacks DESTDIR support,
> which should be included.  

Yes, upstream source lacks DESTDIR support.  If DESTDIR support is included in
upstream source, it would be better for our packaging.  But I don't know
upstream want it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.