[Bug 545046] Review Request: CVector - ANSI C API for Dynamic Arrays

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545046





--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-12-08 10:29:45 EDT ---
More comments:

- The Summary, Group and Requires fields of the subpackages are still not
tabbed correctly.

- LIBDIR should have no effect in %build, since nothing is installed yet. You
can safely change
 make all CC="%{__cc}" CFLAGS="%{optflags}" LIBDIR="%{_libdir}"
to
 make CFLAGS="%{optflags}" %{?_smp_mflags}

where %{?_smp_mflags} enables parallel compilation.

- You are mixing macros: %{buildroot} vs. $RPM_BUILD_ROOT, %{optflags} vs.
$RPM_OPT_FLAGS. Choose a style and stick with it.

- You don't have to ship the static library at all - you can just remove it at
the end of %install.

- Please do not use wildcards where they are not necessary: change
 %{_libdir}/*.so.*
to
 %{_libdir}/libCVector.so.*
and the same thing with *.so, and
 %{_includedir}/*
to
 %{_includedir}/CVector.h

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.