[Bug 545408] Review Request: scantailor - post-processing tool for scanned pages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545408


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-08 18:12:20 EDT ---
Nice programm...


Review:
_______


Good:
- has %clean section
- group ok
- permissions ok
- builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1863668


Needswork:
- desktop file should contain an icon, look in the folder resources/icons or
  resources/appicon.svg to add one
- Please use the %cmake macro
- in %files section: you have to own the directory %{_datadir}/scantailor/
- license is wrong: In COPYING and in the headers is "or at your opionon any
  later version". This is not *yet* relevant, but if there will be a GPLv4, it
  will. -> License is GPLv3+
  In resources/icons/COPYING are several other licenses mentioned.
  -> License is GPLv3+ or GPLv2+ or Public Domain

*****************

  I'm unsure, if this can be reduced to GPLv3+, because this is the least
common
  set.

  This is furthermore a bit strange, because no of this icons are installed
  laterly... A mistake from upstream?

*****************

- why do you BuildRequires and Requires anything with version?
  Don't see any reason to do that atm...
  All Requires are not needed. They are added automatically, because you have
  all the headers as BuildRequires.
- Use the full url to the source, e.g.
  http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
- no %doc:
  e.g. COPYING and resources/icons/COPYING
- rpmlint not clean:
  debuginfo-without-sources, it seems cmake doesn't use the proper compiler
  flags. You should ask upstream about this.
- The COPYING file does not a GPLv3+ license, you should query upstream to add
  a license text.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.