[Bug 543861] Review Request: perl-CGI-Application-Plugin-ActionDispatch - Adds attribute based support for parsing the PATH_INFO of an HTTP request

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543861


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-12-09 00:52:15 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863799
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
78ba11f0e184d7d76ca8d6e166ea20d9621484dd 
CGI-Application-Plugin-ActionDispatch-0.97.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=41,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.32 cusr  0.03
csys =  0.38 CPU)
+ Package perl-CGI-Application-Plugin-ActionDispatch-0.97-1.fc13.noarch =>
Provides: perl(CGI::Application::Plugin::ActionDispatch) = 0.97
perl(CGI::Application::Plugin::ActionDispatch::Attributes) = 0.1
Requires: perl(CGI::Application::Plugin::ActionDispatch::Attributes)
perl(Class::Inspector) perl(Data::Dumper) perl(Exporter) perl(attributes)
perl(strict)
+ Not a GUI application

Suggestions:
remove following lines from spec as you don't need them
Requires:       perl(CGI::Application)
Requires:       perl(Class::Inspector)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.