[Bug 543863] Review Request: perl-CGI-Application-Structured-Tools - Tools to generate and maintain CGI::Application::Structured based web apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543863


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-12-09 00:52:18 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863797
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
1a5a569b7b93c6a931fe8a0349a97c212c71bed1 
CGI-Application-Structured-Tools-0.007.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=21,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.37 cusr  0.09
csys =  0.50 CPU)
+ Package  perl-CGI-Application-Structured-Tools-0.007-1.fc13.noarch=>
Provides: perl(CGI::Application::Structured::Tools)
perl(CGI::Application::Structured::Tools::Starter) = 0.007
Requires: /usr/bin/perl perl(CGI::Application::Structured::Tools::Starter)
perl(Carp) perl(Config::Auto) perl(DBIx::Class::Schema::Loader) perl(English)
perl(ExtUtils::Command) perl(File::Basename) perl(File::Find) perl(File::Spec)
perl(FindBin) perl(Getopt::Long) perl(HTML::Template) perl(Module::Starter)
perl(Module::Starter::App) perl(Test::More) perl(Test::WWW::Mechanize::CGIApp)
perl(base) perl(constant) perl(lib) perl(strict) perl(warnings)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.