[Bug 541661] Merge Review: perl-DBD-SQLite - Self Contained RDBMS in a DBI Driver

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 9 06:04:33 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541661


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-12-09 01:04:32 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863813
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
86cf772505009252d9e1239d8caab37ffc353c05  DBD-SQLite-1.27.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=54, Tests=831, 12 wallclock secs ( 0.21 usr  0.05 sys +  3.15 cusr  0.36
csys =  3.77 CPU)
+ Package perl-DBD-SQLite-1.27-2.fc13.i686 =>
Provides: perl(DBD::SQLite) = 1.27 perl(DBD::SQLite::db) perl(DBD::SQLite::dr)
perl(DBD::SQLite::_WriteOnceHash)
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) perl >= 0:5.006 perl(DBI) >= 1.57
perl(DynaLoader) perl(locale) perl(strict) perl(Tie::Hash) perl(vars)
rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list