[Bug 545433] Review Request: shared-color-profiles - Shared color profiles for color management aware applications

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 9 09:53:00 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545433


Yanko Kaneti <yaneti at declera.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |yaneti at declera.com
         AssignedTo|nobody at fedoraproject.org    |yaneti at declera.com
               Flag|                            |fedora-review+




--- Comment #3 from Yanko Kaneti <yaneti at declera.com>  2009-12-09 04:52:59 EDT ---
Looks good. I would do 

@@ -26,16 +26,18 @@
 %install
 rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
+mkdir Argyll
+mv $RPM_BUILD_ROOT/%{_datadir}/color/icc/Argyll/{README,LICENSE} Argyll/

 %clean
 rm -rf $RPM_BUILD_ROOT

 %files
 %defattr(-,root,root,-)
-%doc AUTHORS COPYING ChangeLog
+%doc AUTHORS COPYING ChangeLog Argyll
 %dir %{_datadir}/color/icc
 %dir %{_datadir}/color/icc/Argyll
-%{_datadir}/color/icc/Argyll/*
+%{_datadir}/color/icc/Argyll/*.icm
 %{_datadir}/color/icc/*.icc

 %changelog


but its up to you.
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list