[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538057


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org




--- Comment #1 from Christoph Wickert <cwickert at fedoraproject.org>  2009-12-09 08:49:55 EDT ---
Let's go through the spec from top to bottom:

Use %global instead of %define, see 
https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define

Use %{_sharedstatedir} instead of %{_var}/lib/, see
http://fedoraproject.org/wiki/Packaging:RPMMacros

Is the license GPLv2 or GPLv2+? Maybe add a doc to clarify?

%{_initrddir} is considered deprecated on Fedora, but still needed on RHEL. You
could catch this with a conditional, see
https://fedoraproject.org/wiki/Packaging/DistTag#Conditionals
(but that's not really that important)

Add -p to install in order to preserve timestamps of the files, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

Please don't use excessive wildcards like %{_usr}/sbin/*
because no other maintainer will know what this means when looking at the spec.

The spec would be more legible if
- you moved %preun before %clean and %files
- you used proper text indention. The content of tags like Name, Version, ...
usually starts at 17 characters (at least in spec generated with
rpmdev-newspec).

Add more docs, at least an AUTHORS file should IMO be there, ChangeLog would be
nice too.

Please use a more common format for your changelogs. Bug numbers should be at
the end of a changelog entry, e.g.
- remove the dependency of rhnmd on nocpulse-common (#494538)
see https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

BTW: there is a typo: "dependecy" instead of "dependency"


The rpmlint warnings are mostly save to ignore, but
- I disagree about service-default-enabled, see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we....
- I don't understand dangerous-command-in-%pre: When you migrate settings from
/home/nocpulse, why remove /var/lib/nocpulse/{bin,var}? This doesn't look
related.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.