[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545720





--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com>  2009-12-09 08:59:39 EDT ---
(In reply to comment #3)

> ***************Summary:
> Everything seem ok, except for the problem I had in executing it (but see
> earlier in the SHOULD list). 
> 
> The authors specify dependencies on python >= 2.6 and pygtk2 >= 2.14:
> http://sourceforge.net/apps/mediawiki/googsystray/index.php?title=Installation
> 
> I tried to remove the Requires line and the python dependence is picked up
> correctly but pygtk2 is not. My proposal is to remove python from the Requires
> and put pygtk2 >= 2.14. But it might be not needed to put the full version as 
> my two f11 and f12 machines have these dependencies already satisfied.
> 
> Peter, what do you think about this? If the problem in usage and the version
> are not blockers I think to approve the package.

I strongly recommend to use version of required components in Requires if
upstream mentioned them. So I really don't like the idea to remove python
version from Requires (the same for PyGTK). Also this might confuse those
packagers, who will package googsystray for other RPM-based distros and who
will rely on Fedora srpm as the starting point.

One more note, Mario - you mislooked one bundled library, already packaged in
Fedora - python-xlib (which is bundled under the name gXlib). This should be
either removed (sources should be fixed to properly use the system library) or
reporter should argue for usage of the bundled copy (was forked and heavily
changed from upstream, for example).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.