[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
bugzilla at redhat.com
bugzilla at redhat.com
Wed Dec 9 16:00:46 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
--- Comment #6 from Mario Ceresa <mrceresa at gmail.com> 2009-12-09 11:00:45 EDT ---
Thanks Peter for your comments!
Hello Leon,
so what it seems to be missing now is:
- Asking to the developers why gXlib has been included and if could be removed.
FYI: I used kdiff3 to check for differences between
python-xlib-0.14-5.fc12.noarch.html and the gXlib included version and there
are many differences.
- Adding to the spec:
Requires: python >= 2.6
Requires: pygtk2 >= 2.14
Requires: hicolor-icon-theme
- Change %{python_sitelib}/%{name}/* to %{python_sitelib}/%{name}/
As far as I understand this should own the directory and all its files.
- I'll post koji's links from home.
Peter: if you spot any error in what I told to Leon, please correct me. I still
have a lot to learn before doing good revisions :)
Mario
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list