[Bug 530090] Review Request: emacs-goodies - Miscellaneous add-ons for Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530090





--- Comment #52 from Arun SAG <sagarun at gmail.com>  2009-12-09 22:39:16 EDT ---
(In reply to comment #51)
> Sorry, we have two patches in the package:
> 
> emacs-goodies-el.texi.patch which ist a small patch. But the only thing what I
> can see in the patch is the try to replace the string 'emacs-goodies' whith
> 'emacs-goodies-el'. This is not good, because the el subpackage should only
> contains the emacs sources of this emacs releated package. this mean, in common
> a user will only install the emacs-goodies package and the el subpackage may be
> only installed, if the user want to examinate or to modified the emacs sources
> of the macros.

Hi, it does the reverse of what you have said :-) . It replaces
'emacs-goodies-el' string with 'emacs-goodies'

> emacs-goodies-el_31.2-1.diff which has a size of approximately 477 Kilobytes
> and lok like the way how applications are pached in Debina. I can't believe,
> that this patch conatins only Fedora specific modifications. So please talk to
> the upstream maintainer how this patch may integrated in the main source tar
> ball.  

It is a upstream provided patch. i got the patch from _debian upstream itself_
http://ftp.de.debian.org/debian/pool/main/e/emacs-goodies-el/emacs-goodies-el_31.2-1.diff.gz
( i will add a comment about it in SPEC file). when applying this patch it
gives birth to 48 more patches :-)

@PSG could you please integrate those patches inside source tar ball if
possible?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.