[Bug 226441] Merge Review: sudo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226441





--- Comment #3 from Karel Klíč <kklic at redhat.com>  2009-12-10 06:15:19 EDT ---
[???] spec file contain source0
http://www.courtesan.com/sudo/dist/sudo-%{version}.tar.gz, but the file has
been moved to http://www.courtesan.com/sudo/dist/OLD/sudo-%{version}.tar.gz
[YES] source files match upstream: af672524b2c854a67612bf4c743f58b8 
sudo-1.7.1.tar.gz
[YES] package meets naming and versioning guidelines 
[YES] specfile is properly named, is cleanly written and uses macros
consistently
[YES] dist tag is present
[YES] build root is correct
[YES] license field matches the actual license
[YES] license is open source-compatible
[YES] license text included in package
[NO] latest version is being packaged: latest version is sudo 1.7.2
[YES] BuildRequires are proper
[YES] compiler flags are appropriate
[YES] %clean is present
[YES] package builds in mock
[YES] debuginfo package looks complete
[NO] rpmlint is silent

$ rpmlint ./sudo-1.7.1-7.fc13.src.rpm 
sudo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 70, tab: line 76)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint ./sudo-1.7.1-7.fc13.i686.rpm 
sudo.i686: E: non-readable /etc/sudoers 0440
sudo.i686: W: file-not-utf8 /usr/share/doc/sudo-1.7.1/ChangeLog
sudo.i686: E: non-standard-dir-perm /var/run/sudo 0700
sudo.i686: E: setuid-binary /usr/bin/sudoedit root 04111
sudo.i686: E: non-standard-executable-perm /usr/bin/sudoedit 04111
sudo.i686: E: non-standard-executable-perm /usr/bin/sudoedit 04111
sudo.i686: E: setuid-binary /usr/bin/sudo root 04111
sudo.i686: E: non-standard-executable-perm /usr/bin/sudo 04111
sudo.i686: E: non-standard-executable-perm /usr/bin/sudo 04111
sudo.i686: W: dangerous-command-in-%post chmod
1 packages and 0 specfiles checked; 8 errors, 2 warnings.

The rpmlint output is appropriate for sudo.

[YES] final provides and requires look sane
[OK] no %check is present
[OK] no shared libraries are added to the regular linker search paths in app
package
[OK] owns the directories it creates
[OK] doesn't own any directories it shouldn't
[YES] no duplicates in %files
[YES] file permissions are appropriate
[YES] scriptlets ok
[YES] code, not content
[YES] documentation is small, so no -docs subpackage is necessary
[YES] %docs are not necessary for the proper functioning of the package
[YES] no headers
[YES] no pkgconfig files
[YES] no libtool .la droppings
[YES] not a GUI app

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.