[Bug 226213] Merge Review: openjade

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226213


Ondrej Vasik <ovasik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #4 from Ondrej Vasik <ovasik at redhat.com>  2009-12-10 07:50:08 EDT ---
Thanks for review...

(In reply to comment #3)
> [NO] rpmlint is silent
> 
> $rpmlint ./openjade-1.3.2-35.fc13.src.rpm 
> openjade.src: W: no-url-tag
> openjade.src:5: E: prereq-use sgml-common >= 0.5
> openjade.src:15: W: unversioned-explicit-obsoletes jade
> openjade.src:16: W: unversioned-explicit-provides jade
> openjade.src:217: W: macro-in-%changelog %doc
> 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
> 
> $rpmlint ./openjade-1.3.2-35.fc13.i686.rpm 
> openjade.i686: W: no-url-tag
> openjade.i686: W: obsolete-not-provided openjade-devel
> openjade.i686: W: self-obsoletion jade obsoletes jade
> 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
> 
> Prereq is used, but Requires (or BuildRequires?) should be used
> "URL: http://openjade.sourceforge.net/" should be added to the SPEC file.

Rpmlint warnings fixed

> 
> [NO] final provides and requires look sane
>      It should probably not contain both "Provides:jade" and "Obsoletes:jade"

Probably could be kept - versioned ... last version is
ftp://ftp.pbone.net/mirror/archive.download.redhat.com/pub/redhat/linux/6.2/en/os/i386/SRPMS/jade-1.2.1-9.src.rpm
from Red Hat 6.2 . I see this harmless, I'll comment this and keep it 

> 
> The following code is no longer necessary, because .la files are not packaged:
> # Fix up libtool libraries
> find $RPM_BUILD_ROOT -name '*.la' | \
>   xargs perl -p -i -e "s|-L$RPM_BUILD_DIR[\w/.-]*||g"  

Dropped...

Fixed and built as openjade-1.3.2-36.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.