[Bug 545895] Review Request: poky-scripts - Poky platform builder utility scripts

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 10 17:12:28 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545895





--- Comment #2 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-12-10 12:12:27 EDT ---
#001: BuildRequires :

 - glibc-devel requires glibc-headers already. You can remove glibc-headers
from BR ( rpm -qR glibc-devel )
 - poky-depends is a meta package. In other words, it doesn't build anything,
hence it should not require an BR. That said, the spec file does not build
anything except copying files to the buildroot. So I think you should remove
all the BRs

#002: Requires:

In your spec file :
poky-scripts requires poky-depends.
poky-depends requires poky-scripts.

It seems to be a circular-dependency.

Shouldn't all the requires (since poky-depends is a metapackage) of
poky-depends be put as requires for poky-scripts and remove poky-depends
entirely ?

#003: check the explicit requires with 
rpm -qR package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list