[Bug 530021] Review Request: moovida - Media Center

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530021





--- Comment #28 from Graeme Gillies <ggillies at redhat.com>  2009-12-10 19:51:53 EDT ---
Hi Matthias,

Thanks heaps for helping me with this and sponsoring me, much appreciated. I'm
going through you comments now (all good points) and making the necessary
changes and testing them in mock, just wanted to get your opinion about the
last point (in moovida 1.0.9 it seems they fixed most the files with the
problem, but only 2 remain). Originally I didn't have the mode 755 on them at
all, but when I ran rpmlint over the rpms I would get

moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/launcher.py 0644 /usr/bin/python
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/tests/test_launcher.py 0644
/usr/bin/python

While I can exectute the scripts themselves and they work, if they are left
without execute permissions moovida still works fine. Should I create a patch
that removes the #!/usr/bin/python line from these scripts, or would it be
better if I re-worked my %files section so instead of blindly including
%{python_sitelib}/* I explicitly indicate all files/directories that need to be
included (and thus leave the defattr settings on these files).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.