[Bug 522895] New Package for Dogtag PKI: pki-native-tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522895


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #8 from Parag AN(पराग) <panemade at gmail.com>  2009-12-11 02:06:18 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1864052
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
135f705c99d00d81c0e7d5058055178d30c181b0  pki-native-tools-1.3.0.tar.gz

Suggestions:
1) you can preserve timestamps
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

2) Note that you can safely remove buildroot tag and cleanup of buildroot in
%install as per given at
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and
http://fedoraproject.org/wiki/PackagingGuidelines#Prepping_BuildRoot_For_.25install

3) Please add newline after you added new changelog entry.

4) why not to choose following as Group?
Group:          System Environment/Base  

5) Is the license tag "GPLv2 with exceptions" is already discussed and approved
by emailing them to fedora-legal-list at redhat.com?


6) Why "Requires: perl" is needed?

7) I don't understand why following is included?
BuildRequires:  bash

See after I removed it , koji scratch build is successful at
http://koji.fedoraproject.org/koji/taskinfo?taskID=1869062

8) Try to use macros in all places in SPEC. See 
https://fedoraproject.org/wiki/Packaging:RPMMacros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.