[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542028


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?

Bug 542028 depends on bug 542500, which changed state.

Bug 542500 Summary: Review Request: php-pear-OLE - Package for reading and writing OLE containers
https://bugzilla.redhat.com/show_bug.cgi?id=542500

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Resolution|                            |ERRATA
             Status|ASSIGNED                    |CLOSED



--- Comment #7 from Remi Collet <fedora at famillecollet.com>  2009-12-11 15:51:12 EDT ---
REVIEW:

+ rpmlint is ok
php-pear-Spreadsheet-Excel-Writer.src: I: checking
php-pear-Spreadsheet-Excel-Writer.noarch: I: checking
php-pear-Spreadsheet-Excel-Writer.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines
+ License ok : LGPLv2+
+ License is upstream (LGPL)
+ spec in english and legible
+ no license file in sources is provided
+ sources match the upstream sources
15691145ca8ac71ccd501a38892ee64a  Spreadsheet_Excel_Writer-0.9.2.tgz
+ Source URL ok
+ build  on F12.x86_64
+ BuildRequires (php-pear >= 1:1.4.9-1.2) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ no documentation
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in koji
+ no test suite
+ scriptlets ok
- Final Requires 
php >= 4.1.0
php-pear(OLE) >= 0.5
/usr/bin/pear
+ Final Provides ok
php-pear(Spreadsheet_Excel_Writer) = 0.9.2
php-pear-Spreadsheet-Excel-Writer = 0.9.2-1.fc8
+ Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=1870628

All is ok, except the dependency on httpd...

Just remove the php 4.1.0 (as for previous #542500, just requires php-common
when version check is necessary).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.