[Bug 546169] Review Request: libtar-ng : tar library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546169





--- Comment #21 from Michael Schwendt <mschwendt at gmail.com>  2009-12-14 04:02:05 EDT ---
> - bump soname in the code from 1.2.11 to 1.2.12

Caution! You did NOT change the internal SONAME at all. It is still
"libtar.so.1".
You also wrote "Bump the soname" in the README. Distribution packagers (but
also developers and ordinary users) will run wild if you don't get the library
versioning right.


* Please run "rpmlint -i" on the src.rpm and the built binary rpms. It prints
some helpful warnings. (This is also in the Review Guidelines)

* "BuildRequires: libtool" is not needed for properly prepared source tarballs.

* To have the top source directory file name contain the %{version} would be
good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.