[Bug 546169] Review Request: libtar-ng : tar library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546169





--- Comment #25 from Huzaifa S. Sidhpurwala <huzaifas at redhat.com>  2009-12-14 04:38:15 EDT ---
(In reply to comment #21)
> > - bump soname in the code from 1.2.11 to 1.2.12
> 
> Caution! You did NOT change the internal SONAME at all. It is still
> "libtar.so.1".
> You also wrote "Bump the soname" in the README. Distribution packagers (but
> also developers and ordinary users) will run wild if you don't get the library
> versioning right.
> 
> 
As said later, there is no ABI change yet, hence it was wrong for me to mention
"soname bump" in README, removed that.
SRPM: http://huzaifas.fedorapeople.org/srpms/libtar-ng-1.2.12-2.fc12.src.rpm
SPEC: http://huzaifas.fedorapeople.org/spec/libtar-ng.spec

> * Please run "rpmlint -i" on the src.rpm and the built binary rpms. It prints
> some helpful warnings. (This is also in the Review Guidelines)
rpmlint is happy now
> 
> * "BuildRequires: libtool" is not needed for properly prepared source tarballs.
> 
Does that mean i have to include a copy of libtool in the source ball,
I saw a few libraries, but none of them really seem to do it.
Any idea?
> * To have the top source directory file name contain the %{version} would be
> good.

--- Comment #26 from Huzaifa S. Sidhpurwala <huzaifas at redhat.com>  2009-12-14 04:38:46 EDT ---
(In reply to comment #21)
> > - bump soname in the code from 1.2.11 to 1.2.12
> 
> Caution! You did NOT change the internal SONAME at all. It is still
> "libtar.so.1".
> You also wrote "Bump the soname" in the README. Distribution packagers (but
> also developers and ordinary users) will run wild if you don't get the library
> versioning right.
> 
> 
As said later, there is no ABI change yet, hence it was wrong for me to mention
"soname bump" in README, removed that.
SRPM: http://huzaifas.fedorapeople.org/srpms/libtar-ng-1.2.12-2.fc12.src.rpm
SPEC: http://huzaifas.fedorapeople.org/spec/libtar-ng.spec

> * Please run "rpmlint -i" on the src.rpm and the built binary rpms. It prints
> some helpful warnings. (This is also in the Review Guidelines)
rpmlint is happy now
> 
> * "BuildRequires: libtool" is not needed for properly prepared source tarballs.
> 
Does that mean i have to include a copy of libtool in the source ball,
I saw a few libraries, but none of them really seem to do it.
Any idea?
> * To have the top source directory file name contain the %{version} would be
> good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.