[Bug 530198] Review Request: rubygem-columnize - Sorts an array in column order

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530198


Jeroen van Meeuwen <kanarip at kanarip.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(kanarip at kanarip.c |
                   |om)                         |




--- Comment #4 from Jeroen van Meeuwen <kanarip at kanarip.com>  2009-12-14 08:20:40 EDT ---
(In reply to comment #1)
> Some notes:
> 
> * %check
>   - Please add %check section as this package contains test/
>     directory
> 

Fixed.

> * License
>   - Well, while I believe this is under GPLv2+, "README" says
>     this is under GPLv2, so it is safer that the license tag
>     is changed to GPLv2.
> 

OK, fixed.

> * %define -> %global
>   - We now prefer to use %global rather than %define.
> 

Fixed.

> * unused macro
>   - The defined macro %ruby_sitelib does not seem to be used.  

Fixed.

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-columnize.spec
New SRPM:
http://www.kanarip.com/custom/f12/SRPMS/rubygem-columnize-0.3.1-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.