[Bug 542715] Review Request: RabbitVCS - Easy version control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542715


ELMORABITY Mohamed <melmorabity at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |melmorabity at fedoraproject.o
                   |                            |rg




--- Comment #1 from ELMORABITY Mohamed <melmorabity at fedoraproject.org>  2009-12-14 11:56:49 EDT ---
Hi,

I'm not (yet) a packager, anyway I'd like to make an informal review of your
package.

* The spec. file in your SRPM is not the same than the one you gave the URL. I
considered the last one for this review (the .spec refers to the version 0.12.1
of rabbitvcs whereas the SRPM refers to 0.12). Please upload an updated version
of your SRPM.

* You should use "%global" [1] instead of "%define" in
       %define title RabbitVCS

* Your BuildRoot looks very strange. Why not using the standard way to declare
it?
       BuildRoot:     
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

* It seems there is no arch-dependent file installed by your package so you
should add in your .spec header this line :
       BuildArch:      noarch


[1]
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

Once your SRPM updated, the review will be continued with more details.


[1]
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.