[Bug 518441] Review Request: ike - Shrew Soft VPN Client For Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518441


Joshua Roys <roysjosh at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roysjosh at gmail.com




--- Comment #1 from Joshua Roys <roysjosh at gmail.com>  2009-12-14 13:52:05 EDT ---
Hello,

(The official 2.1.5 is out now, by the way.)

I'm not entirely sure where you get the "Sleepycat" license from...  is the
license used in LICENSE.TXT just word-for-word identical for that?  Is there an
email thread somewhere?

Two rpmlint issues:
Fix the init script (see below).
Use the %cmake macro... this avoids/fixes a rpmlint error on the debuginfo
package (see below).
http://fedoraproject.org/wiki/Packaging/cmake
https://fedoraproject.org/wiki/Packaging/Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_packaging_issues
(esp. the note about CFLAGS, ...)

$ rpmlint -vi /var/lib/mock/fedora-12-x86_64/result/ike-*
ike.src: I: checking
ike.x86_64: I: checking
ike.x86_64: W: service-default-enabled /etc/rc.d/init.d/iked
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

ike-debuginfo.x86_64: I: checking
ike-debuginfo.x86_64: E: debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

3 packages and 0 specfiles checked; 1 errors, 1 warnings.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.