[Bug 546620] Review Request: git-bugzilla - Attach patches to a bugzilla bug

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546620


Joshua Roys <roysjosh at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roysjosh at gmail.com




--- Comment #2 from Joshua Roys <roysjosh at gmail.com>  2009-12-14 14:26:18 EDT ---
Hello,

You could use the snapshot link in the comments instead of the git
clone/archive:
http://git.collabora.co.uk/?p=user/cassidy/git-bugzilla;a=snapshot;h=fc2be928f49569646058812bd0f41251b837bc04;sf=tgz

Here's an unofficial review:

MUST:
* rpmlint
$ rpmlint -vi
/var/lib/mock/fedora-12-x86_64/result/git-bugzilla-0-0.1.20091211git.fc12.*
git-bugzilla.noarch: I: checking
git-bugzilla.src: I: checking
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

* named according to guidelines
* spec is %{name}.spec
* meets package guidelines
* license is ok: GPLv2+
* license tag matches source
~ n/a no separate license file
* spec file is written in American English
* ... and is legible
* source matches
* builds on x86_64 (as noarch)
* builds under mock (BuildRequires are correct)
~ n/a locales
~ n/a ldconfig
* does not bundle copies of system libraries
~ n/a relocatable
* does not make any directories
* %files list is ok
* permissions are correct
* %clean section is correct
* macro usage is consistent
* package contains code
~ n/a no large doc files
~ n/a no doc files
~ n/a no header files
~ n/a no static libraries
~ n/a no pkgconfig files
~ n/a no library files
~ n/a no -devel subpackage
* no .la files
~ n/a no GUI app
* doesn't duplicate file/dir ownership
* %install has rm -rf $RPM_BUILD_ROOT
* file names are valid UTF-8

SHOULD:
- If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
- The description and summary sections in the package spec file should contain
translations for supported Non-English languages, if available.

Hope to help.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.