[Bug 547427] Review Request: cciss_vol_status - show status of logical drives attached to HP Smartarray controllers

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 14 19:54:32 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=547427





--- Comment #1 from Joshua Roys <roysjosh at gmail.com>  2009-12-14 14:54:30 EDT ---
Updated version based on comments:

Spec URL: http://www.stl.gtri.gatech.edu/jroys/fedora/cciss_vol_status.spec
SRPM URL:
http://www.stl.gtri.gatech.edu/jroys/fedora/cciss_vol_status-1.06-2.fc11.src.rpm

- removed INSTALL
- removed README (it was two lines long, one of which referenced INSTALL and
the other COPYING)
- standardized sourceforge url
- removed commented out *Requires

$ rpmdev-diff SRPMS/cciss_vol_status-1.06-{1,2}*
diff -r -Nup cciss_vol_status-1.06-1.fc11.src/cciss_vol_status.spec
cciss_vol_status-1.06-2.fc11.src/cciss_vol_status.spec
--- cciss_vol_status-1.06-1.fc11.src/cciss_vol_status.spec 2009-12-14
10:34:49.000000000 -0500
+++ cciss_vol_status-1.06-2.fc11.src/cciss_vol_status.spec 2009-12-14
14:49:01.000000000 -0500
@@ -1,18 +1,15 @@
 Name:           cciss_vol_status
 Version:        1.06
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Show status of logical drives attached to HP Smartarray
controllers

 Group:          Applications/System
 License:        GPLv2+
 URL:            http://cciss.sourceforge.net/#cciss_utils
-Source0:       
http://sourceforge.net/projects/cciss/files/%{name}/%{name}-%{version}.tar.gz
+Source0:       
http://downloads.sourceforge.net/cciss/%{name}-%{version}.tar.gz
 Patch0:         cciss-fix-compile.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

-#BuildRequires:  
-#Requires:       
-
 %description
 A very lightweight program to report the status of logical drives on
 Smart Array controllers and also fibre channel attached MSA1000.
@@ -39,11 +36,15 @@ rm -rf $RPM_BUILD_ROOT

 %files
 %defattr(-,root,root,-)
-%doc AUTHORS ChangeLog COPYING INSTALL README
+%doc AUTHORS ChangeLog COPYING
 %attr(0755,root,root) %{_bindir}/%{name}
 %{_mandir}/man8/%{name}*


 %changelog
+* Mon Dec 14 2009 Joshua Roys <roysjosh at gmail.com> - 1.06-2
+- standardize sourceforge url
+- remove INSTALL and README (it's two lines long) from %%doc
+
 * Mon Dec 14 2009 Joshua Roys <roysjosh at gmail.com> - 1.06-1
 - initial packaging

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list