[Bug 547017] Review Request: perl-CGI-Application-Plugin-Config-Simple - Add Config::Simple support to CGI::Application
bugzilla at redhat.com
bugzilla at redhat.com
Tue Dec 15 08:29:20 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547017
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-12-15 03:29:19 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1872515
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
3ebb71136636bf20394c6be3e359cbed0d43510e
CGI-Application-Plugin-Config-Simple-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=20, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.03 cusr 0.01
csys = 0.07 CPU)
+ Package perl-CGI-Application-Plugin-Config-Simple-1.01-1.fc13.noarch=>
Provides: perl(CGI::Application::Plugin::Config::Simple) = 1.01
Requires: perl(CGI::Application) perl(Config::Simple) perl(base) perl(strict)
perl(vars) perl(warnings)
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list