[Bug 542166] Review Request: patricia-trie - Java prefix tree library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542166


ELMORABITY Mohamed <melmorabity at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |melmorabity at fedoraproject.o
                   |                            |rg




--- Comment #1 from ELMORABITY Mohamed <melmorabity at fedoraproject.org>  2009-12-15 10:04:12 EDT ---
Hi,

I'm not (yet) a packager, anyway I'd like to make an informal review of your
package.

* You should not rely explicitely on OpenJDK in your BuildRequires; use
instead:
     Buildrequires:   java-devel >= 1:1.6.0
  as suggested in
https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
  Don't forget by the way to add a Java runtime by using:
     Requires: java >= 1:1.6.0
  Did you tried to build your package with gcj by the way?

* You should maybe in your javadoc subpackage add a Requires on "%{name} =
%{version}-%{release}" also, as recommended here:
https://fedoraproject.org/wiki/Packaging/Java#ant_2

Except these two points, your package seems OK. I rebuild your SRPM, it works
fine and rpmlint doesn't complains :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.