[Bug 226175] Merge Review: mx

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226175





--- Comment #2 from Dan Horák <dan at danny.cz>  2009-12-18 05:30:19 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     70b4423a1f4d690976d57ded91ec3e9a71c6c0a3  egenix-mx-base-3.1.1.tar.gz
OK* package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
BAD latest version is being packaged.
Ok BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
BAD file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
BAD documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel subpackage
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- this package is a collection of python modules and should follow the
guideline for naming python modules
(https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29),
because this a merge review it will be sufficient to add a Provides that will
match the guideline (python-mx = %{version}-%{release})
- version 3.1.2 was released

- rpmlint complains a bit
mx.x86_64: W: self-obsoletion mx2 <= 3.1.1-5.fc13 obsoletes mx2 = 3.1.1-5.fc13
    => if the reason for these is an upgrade path from an earlier version
present in F<=10, it could be dropped
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/Stack/mxStack/mxStack.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/BeeBase/mxBeeBase/mxBeeBase.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/UID/mxUID/mxUID.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/URL/mxURL/mxURL.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/Tools/mxTools/mxTools.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/Proxy/mxProxy/mxProxy.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/TextTools/mxTextTools/mxTextTools.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/Queue/mxQueue/mxQueue.so 0775
mx.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mx/DateTime/mxDateTime/mxDateTime.so 0775
    => chmod will fix them, AFAIK it's caused by the python dist/setup-tools
mx-devel.x86_64: W: no-documentation
    => no problem, but you can check if some of the existing docs could be
moved here
- the documentation contains a number of PDF files making 90% of the total
package size and 65% of installed size and thus deserves a docs subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.