[Bug 542559] Review Request: rubygem-thor - Scripting framework that replaces rake, sake and rubigen

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542559


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-12-18 13:53:08 EDT ---
Some notes:

* Source
  - Source0 in srpm differs from what I could download from
    the URL written in the spec file
-------------------------------------------------------------
5fa79d6ca562a39c72c89f5447a3fbd5  thor-0.12.0.gem
32e034949be3726ff1857d0edeae6566 
rubygem-thor-0.12.0-1.fc13.src/thor-0.12.0.gem
-------------------------------------------------------------
    (and the contents of two gems actually differ)

* Requires
  - bin/rake2thor contains:
-------------------------------------------------------------
     8  require 'rake'
-------------------------------------------------------------
    As the Summary of this spec file says "that replaces rake,",
    I think it is admitted to add "Requires: rubygem(rake)" and
    this should surely be added.

  - lib/thor/shell/color.rb contains:
-------------------------------------------------------------
    98            @diff_lcs_loaded = begin
    99              require 'diff/lcs'
   100              true
   101            rescue LoadError
   102              false
   103            end
-------------------------------------------------------------
    I guess "diff/lcs" dependency is surely optional, however
    as Fedora already has rubygem-diff-lcs, you may want to
    add this dependency (however this is up to what you think)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.