[Bug 542715] Review Request: RabbitVCS - Easy version control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542715





--- Comment #6 from ELMORABITY Mohamed <melmorabity at fedoraproject.org>  2009-12-19 06:15:21 EDT ---
Good initiative to refer to the bug 474428 in your .spec file -:)
Anyway I don't think it's a good thing that the ExcludeArch is a good idea
here. First it is not appropriated since this tag is only used when a package
cannot be build/doesn't work in a particular arch (and it's not the case here
^^). Moreover, you exclude 64-bit users like me who want that very useful
package ^^. And finally, there's several packages that have the same issue (I
talked about phatch above) and that are arch-specific whereas they don't
contain any binary.
You should remove ExcludeArch and leave things like this for the arch. of your
package :-)

Be careful not to mix %{buildroot} and $RPM_BUILD_ROOT in your spec file:
  
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

About the doc: since the installer installs itself the files AUTHORS, COPYING
and MAINTAINERS to %{_defaultdocdir}/%{name}, I suggested before to flag them
as %doc by replacing this line in your %files section:
   %{_defaultdocdir}/%{name}/*
By
   %dir %{_defaultdocdir}/%{name}
   %doc %{_defaultdocdir}/%{name}/*
(and by this way, the fact that  %{_defaultdocdir}/%{name} is not owned by your
package is solved).
But if you use this like you did:
   %doc AUTHORS COPYING MAINTAINERS
rpmbuild will automatically copy them from your build directory into
%{_defaultdocdir}/%{name}-%{version} and you'll have duplicate files in your
RPM.
If you keep « %doc AUTHORS COPYING MAINTAINERS », you should exclude the
%{_defaultdocdir}/%{name} directory from being included in RPM by removing it
for example in %install ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.