[Bug 546620] Review Request: git-bugzilla - Attach patches to a bugzilla bug

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546620





--- Comment #6 from Lubomir Rintel <lkundrak at v3.sk>  2009-12-19 11:31:46 EDT ---
(In reply to comment #2)
> Hello,
> 
> You could use the snapshot link in the comments instead of the git
> clone/archive:
> http://git.collabora.co.uk/?p=user/cassidy/git-bugzilla;a=snapshot;h=fc2be928f49569646058812bd0f41251b837bc04;sf=tgz

Good idea. Done.

> Here's an unofficial review:

Why unofficial? I see you're in packager group now.

> SHOULD:
> - If the source package does not include license text(s) as a separate file
> from upstream, the packager SHOULD query upstream to include it.

This is basically just one file; I'm not sure if upstream would include license
separately.

> - The description and summary sections in the package spec file should contain
> translations for supported Non-English languages, if available.

Not available.

(In reply to comment #3)
> Shouldn't this be patched, so bugzilla.redhat is the default one and *not* the
> gnome one?
> 
> Of course, this would be fedora/red hat specific, but the reasonablest way.  

I'm reluctant to do a default here (I don't think people would use this much
against Red Hat bugzilla). I've made it work against Red Hat bugzilla (oh,
sorry for the attachments above) and removed GNOME bugzilla default. Now it
demands that you configure a bugzilla instance to use and provides examples for
GNOME and Red Hat bugzillas.

New package:

SPEC: http://v3.sk/~lkundrak/SPECS/git-bugzilla.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/git-bugzilla-0-0.2.20091211git.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.