[Bug 541978] Review Request: pulseaudio-equalizer - PulseAudio Equalizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541978


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak at v3.sk
         AssignedTo|nobody at fedoraproject.org    |lkundrak at v3.sk
               Flag|                            |fedora-review?




--- Comment #4 from Lubomir Rintel <lkundrak at v3.sk>  2009-12-20 04:11:20 EDT ---
Hicham, this looks useful and you've done a good job packing this,
unfortunately upstream knows dick about properly maintaining a project. I'm
still willing to review this, but am hesitant to approve it until upstream's
problems that make it impossible to do a proper review are gone.

Legend:
  * good
  - bad
  ॐ wtf

* Package is named properly
* Version correct and matches upstream
ॐ Can't verify if sources match, could not download it
   (see below)
* License is ok
ॐ License is present in source tarball and installed as %doc
   (see below)
- Spec file is clean and legible
  In fact it mostly is, just have to get rid of that pre-%setup voodoo in %prep
- Does not build
  Enough said above. What you do in %prep is not only unnecessary, but also
totally sick. In my case it BUILD/usr in the package and deleted it :) Please,
never do anything outside your %{buildsubdir}. Unpack the other sources under
it and if necessary create additional top-level directory with %setup -c.
* Filelist sane
* Requires/provides sane

Action points:

Please ask upstream for anonymously accessible address of tarball which they
use to produce their .debs, eventually publish them unless they already do.

Please ensure that tarball contains a license file.

I believe a sane source tarball would make the %prep shit unnecessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.