[Bug 549189] Review Request: Djagios -> Djagios is an open source Nagios web based configuration tool with a co mplete Python Nagios API..

Mon Dec 21 12:52:46 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549189

Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net

--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2009-12-21 07:52:46 EDT ---
Just some quick comments on your spec file.

Please check your files with rpmlint.

[fab at localhost SRPMS]$ rpmlint djagios-0.1.3-1.src.rpm 
djagios.src: W: summary-ended-with-dot Djagios is an open source Nagios web
based configuration tool with a complete Python Nagios API..
djagios.src: E: summary-too-long Djagios is an open source Nagios web based
configuration tool with a complete Python Nagios API..
djagios.src: W: name-repeated-in-summary Djagios
djagios.src: E: description-line-too-long Djagios is an open source Nagios web
based configuration tool with a complete Python Nagios API.
djagios.src: E: description-line-too-long The main goal of the tool was to make
Nagios usable for non-Nagios admins. The initial install and configuration
would have to be done by Nagios administrators. But once done ordinary users
can add servers, appliances, devices, services themselves.
djagios.src: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 3 errors, 3 warnings.

- Please replace '%define' with '%global' according to the Packaging Guidelines

http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

- You must use macros.
  http://fedoraproject.org/wiki/How_to_create_an_RPM_package#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.