[Bug 529375] Review Request: emerillon - A map viewer for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529375





--- Comment #9 from Simon Wesp <cassmodiah at fedoraproject.org>  2009-12-22 05:25:03 EDT ---
(In reply to comment #8)
> $RPM_BUILD_DIR is not the same as %{buildroot}. 
this is correct

> I'm not sure of the newer style macro for BUILD_DIR 
%{builddir}
Please take a look in /usr/lib/rpm/macros (LINE 836)


(In reply to comment #7)
> Simon, is this package okay?
just a few notes...
Peter, perhaps it is better to use the name-macro instead of the name in the
file list!

It would be nice if you could add a  / to the directories in the filelist.
%{_bindir}/%{name}
%{_libdir}/%{name}
both looks like a file
%{_bindir}/%{name}
%{_libdir}/%{name}/
differs directory and file

in the includedir you should use a "*" instead of the versionnumber. it's
easier for an update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.