[Bug 549915] Review Request: FreeMat - An interpreted, matrix-oriented development environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549915


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-12-22 18:29:13 EDT ---
Ugh. "blas.ini" in %{_bindir}??

- You're not owning %{_datadir}/%{name}-%{version}/, add
 %dir %{_datadir}/%{name}-%{version}/
to the main %files.

- Are the files in
 %{_datadir}/%{name}-%{version}/help
used by the main program? In that case you don't need to make a separate %doc
package. On the other hand if the files are not used by the program itself, use
%{_docdir} instead of %{_datadir}.

- I think you are missing some buildrequires, since judging from the project
homepage FreeMat links against BLAS. Actually, you should link against ATLAS,
which is faster than reference BLAS & LAPACK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.