[Bug 548824] Review Request: security-menu - Menu Structure for the Security Spin
bugzilla at redhat.com
bugzilla at redhat.com
Wed Dec 23 00:03:28 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=548824
--- Comment #7 from Christoph Wickert <cwickert at fedoraproject.org> 2009-12-22 19:03:27 EDT ---
Some more comments on the spec:
drop %define ..., it is not needed. If you need such things, use %global
instead, see
https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define
Drop Requires(pre) and add
Requires: redhat-menus
for directory ownership.
As long as we have no icons, remove the icon-cache scriptlets. When we have,
add the latest version of the scripts again. Yours are slightly outdated
compared to
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list