[Bug 548877] Review Request: python-virtualenv - Virtual Python Environment builder

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 23 13:57:43 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548877


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org




--- Comment #3 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-23 08:57:42 EDT ---
Could you post the new url to the spec file?

The one above should be an old one, because there are still the spaces.


Just some other comments:
- %gobal over %define
  see:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- BR: python-setuptools-devel is not needed, python-setuptools is enought

- How about modifying the description a bit?
  You could use %{python_sitelib} instead of
``/usr/lib/python2.4/site-packages``, so the example in the description will
always be uptodate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list