[Bug 550100] Review Request: python-olpcgames - Utilities for developing games on the OLPC platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550100


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-23 12:14:23 EDT ---
Just a few comments for now, because I'm unsure, if reviewing this is the right
procedure...

- use %global and not %define
 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- permissions of buildmanifest.py need to be 664, like they where.
  But this is no executable script and contains #!/usr/bin/env
  Fix this with [1] to delete the shebang and not touching the permissions.


[1]
https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_files



About the procedure:
It seems, the original submitter does not care anymore about this package and
you want to take it.

http://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers

would be the best thing to do in this case and no new review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.