[Bug 550143] Review Request: webattery - Command line tool to display battery status

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550143


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org
             Blocks|                            |177841(FE-NEEDSPONSOR)




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-23 13:27:29 EDT ---
Just a few comments, because I'm no sponsor anyway:

- $ rpmlint webattery-1.1-1.fc12.src.rpm x86_64/webattery-*
webattery.src: W: no-cleaning-of-buildroot %install
webattery.src: W: no-buildroot-tag
webattery-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/webattery-1.1/src/webattery.c
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

  * in %install needs to be rm -rf %{buildroot} as first line
  * no-buildroot-tag can be ignored, this is not needed anymore in fedora
    (only if you want to import it in EL-5, too...)
  * webattery.c needs to be 644, please change this in %install

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.