[Bug 529374] Review Request: ethos - Plugin framework for GLib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529374


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org




--- Comment #15 from Christoph Wickert <cwickert at fedoraproject.org>  2009-12-24 06:30:40 EDT ---
(In reply to comment #12)
> as far as i understand it right, you should use wildcards for every
> versionnumber in your filelist.

Not everyone, but where it makes sense.


(In reply to comment #14)

> %files -f %{name}.lang
...
> %{_libdir}/lib%{name}*

...
> %files devel
...
> %{_libdir}/*.so

This will result in files listed twice because 
%{_libdir}/lib%{name}*
and 
%{_libdir}/*.so
both include
/usr/lib64/libethos-1.0.so
/usr/lib64/libethos-ui-1.0.so

Correct is 
%{_libdir}/libethos*.so.*
for the base package (this is what Peter is using right now).


> %{_datadir}/gtk-doc/html/%{name}/

this should be 
%doc %{_datadir}/gtk-doc/html/%{name}/


The python and the vala package should be in the group
Development/Languages
instaed of
Development/Libraries


What owns/provides /usr/share/gir-1.0/? Make sure the dir is not unowned.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.