[Bug 548795] Review Request: belier - Generates scripts allowing you to chain many ssh connections

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548795





--- Comment #2 from Florent Le Coz <louizatakk at fedoraproject.org>  2009-12-24 09:27:01 EDT ---
(In reply to comment #1)
> Just some quick comment on your spec file.
> 
Thank you

> - Please use '%global' instead of '%define'
done

> - Is 'Requires: python' really needed?  Isn't it pulled in automatically by
> RPM?
You're right, removed.

> - '-n %{name}-%{version}' is the default.  '%setup -q' is enough.
I know, but I thought this way was clearer and easier to maintain.
But, ok, fixed.

> - Please ask upstream to include a COPYING file.
Done on their mailing list :
http://sourceforge.net/mailarchive/message.php?msg_name=4B33734C.30509%40fedoraproject.org

> - You must use macros.  Replace '/usr/bin/bel' with ' %{_bindir}/bel'
>   https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Macros
Done

> - Your package provides an egg.  Please have a look at the following page
>   https://fedoraproject.org/wiki/Packaging/Python/Eggs  
Sorry but I don't understand what is wrong with my package, here.
The egg is correctly created and installed in %{python_sitelib} using the
upstream setuptools script. The page you ask me to read doesn't say much more
than that...

I will provide a new version of my package once the last point is fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.