[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517743





--- Comment #13 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-26 21:18:28 EDT ---
(In reply to comment #9)
> You can choose, between
> - adding a comment above the License: field
> - refer to a file upstream, where anything is explained
> - breack down in the %files section.
> 
> 
> See [1] for further information.
> 
> [1]
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios  

This is a MUST. ;)
If you have multiple licenses, you have to e.g. refer to in this case
readme.txt or say in a comment, which files have which license.

wxWidgets is GPL compatible (see https://fedoraproject.org/wiki/Licensing ), so
anything under wxWidgets can be relicensed under GPL. BUT in fact, Josiah has
already done that:
from readme.txt:
'''
The portions of STCStyleEditor.py included in StyleSetter.py, which is used to

support styles, was released under the wxWindows license [...]
'''

But the whole file itself is GPL -> no wxWidgets everywhere.


What is copyrighted under LGPL?
There is a lgpl.txt, but that's it. Or am I wrong?

So, it stays for me: GPLv2.

@ Josiah: Correct me, if I'm wrong ;)


########################################

Some other issues:
- $RPM_BUILD_ROOT%{_datadir}/%{name} is created, but empty (rest of old icon
path) -> not needed anymore.
- sed -i -e "s;PYTHONPATH;%{python_sitelib};g" %{SOURCE1}
  has no effect. There is no pythonpath in the .desktop ( yet? ;) )
- Don't copy *.pyc and *pyw.
  They are created later in the /usr/lib/rpm/brp-python-bytecompile part
anyway.
  See
https://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
  MUST: don't install them, and Josiah please don't include them (same for
*.dll);)
- changelog format:
  There is '* new version' -> '- new version'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.