[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544964





--- Comment #2 from Matthew Kent <mkent at magoazul.com>  2009-12-28 01:04:28 EDT ---
(In reply to comment #1)
> Well,
> 
> * License
>   - I guess the license for this package should
>     be "GPL+ or Ruby or Artistic".
> 

Sure! Fixed.

> * rcov for %check
>   - build.log says:
> -------------------------------------------------------
>     89  + rake test
>     90  Hoe.new {...} deprecated. Switch to Hoe.spec.
>     91  (in
> /builddir/build/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
>     92  which: no dot in
> (/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/usr/local/sbin)
>     93  /usr/bin/ruby -w -Ilib:ext:bin:test -e 'require "rubygems"; require
> "test/unit"; require "test/test_mime_type.rb"; require
> "test/test_mime_types.rb"' 
>     94  RCov is not available. In order to run rcov, you must: sudo gem install
> spicycode-rcov
> -------------------------------------------------------
>     I don't know well about RCov, however when I install
>     rubygem-rcov, rake check fails as:
> -------------------------------------------------------
> [tasaka1 at localhost mime-types-1.16]$ rake test --trace
> (in
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
> Hoe.new {...} deprecated. Switch to Hoe.spec.
> rake aborted!
> undefined method `test_files' for #<Hoe:0xb75d9a78>
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:53
> /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/lib/rcov/rcovtask.rb:91:in `initialize'
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51:in
> `new'
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `load'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `raw_load_rakefile'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2016:in `load_rakefile'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in
> `standard_exception_handling'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2015:in `load_rakefile'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1999:in `run'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in
> `standard_exception_handling'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1997:in `run'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
> /usr/bin/rake:19:in `load'
> /usr/bin/rake:19
> -------------------------------------------------------
>   ref: http://bugs.gentoo.org/288996
>   Would you check this?  

Rcov will produce a pretty report of the test coverage but is by no means
necessary for the unit tests themselves. 

As to the error it looks like the Rakefile wants a specific version of rcov, 

p.extra_dev_deps  << %w(rcov ~>0.8)

while Fedora is on 0.9.6. I'll file a ticket with the upstream project about
updating it to something more recent.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.