[Bug 549286] Review Request: rubygem-merb-core - Lightweight Ruby-based MVC framework for web development

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549286





--- Comment #3 from Matthew Kent <mkent at magoazul.com>  2009-12-28 01:47:57 EDT ---
Thank you for the review!

(In reply to comment #2)
> The example provided by you works for me.
> 
> Some remarks:
> 
> * Requires
>   Would you check if the following dependencies are
>   not needed?
> 
>   - ebb
>     from lib/merb-core/rack/adapter/ebb.rb
> 

merb supports multiple frontend webservers via adapters and the -a parameter:

"The rack adapter to use to run merb (default is mongrel)[mongrel, emongrel,
thin, ebb, fastcgi, webrick]"

As they use mongrel by default I chose to add it as a dependency and none of
the others. Not having those gems installed doesn't inhibit functionality of
the app.

The gem doesn't depend on any adapter at all oddly enough, though one could use
webrick that ships with ruby itself.

>   - ruby-debug
>     from lib/merb-core/config.rb
> 

No package for this currently, though it looks useful. Doesn't look to block
the main function of merb-core though and isn't listed as a primary or
development dependency.

I'll add to my list of things to package.

>   - ruby-prof
>     from lib/merb-core/core_ext/kernel.rb
>          lib/merb-core/rack/middleware/profiler.rb
> 

No package for this currently, though it looks useful. Doesn't look to block
the main function of merb-core though and isn't listed as a primary or
development dependency.

I'll add to my list of things to package.

>   - swiftiply
>     from lib/merb-core/rack/adapter/evented_mongrel.rb
>          lib/merb-core/rack/adapter/swiftiplied_mongrel.rb
> 
>   - thin
>     from lib/merb-core/rack/adapter/thin.rb
> 
>   - thin-turbo (could not find on gems.rubyforge.org)
>     from lib/merb-core/rack/adapter/thin_turbo.rb
> 

See above note about adapters. Will look into the thin-turbo issue and file a
ticket if necessary.

>   - webrat
>     from lib/merb-core/test.rb

The Rakefile lists it as a development dependency and I believe it's only
required to run the merb test suite which isn't in this version. I'll be sure
to revisit it when the next version of merb, which appears to come with the
test suite, is released.

>   - webrick
>     from lib/merb-core/rack/adapter/webrick.rb  

This ships with ruby, though actually using it as an adapter doesn't seem to
work with my example (404's each time). I should file an upstream bug for this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.