[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 30 08:46:07 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544964





--- Comment #5 from Matthew Kent <mkent at magoazul.com>  2009-12-30 03:46:05 EDT ---
(In reply to comment #4)
> Well, what I am concerned here is that $ rake test actually
> _fails_ is Fedora rubygem-rcov is installed (as I wrote in the
> comment 2), not just warnings, so people who has rubygem-rcov installed
> cannot rebuild your srpm, which I think should be avoided.
> 
> It seem that the following line
> --------------------------------------------------
>     53      t.test_files = hoe.test_files
> --------------------------------------------------
> in Rakefile seems unneeded. Would you again check this?  

Ah sorry, you're 100% right - I forget people may build without mock. I'll
remove the line during the test phase.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list