[Bug 508351] Review Request: josm - java openstreetmap editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351





--- Comment #22 from Andrea Musuruane <musuruan at gmail.com>  2009-12-30 11:15:02 EDT ---
Some quick notes. I hope to give a deeper look soon.

* Summary:        An editor for  OpenStreetMap (OSM)
                               ^^
There should be only one space.

* Patches must be named %{name}-<summary>.patch. Even better they should be
named %{name}-<version>-<summary>.patch and not <summary>.patch.

* Almost the same rule apply for Sources. Therefore josm-generate-tarball.sh

* You must not package plugins provided by 
http://svn.openstreetmap.org/applications/editors/josm/plugins/ 
with this package because they are independent. 

Please remove its checkout from the generate-tarball script.

* Usually shell startup scripts are packaged with the .sh exension and
installed in /usr/bin without it.

* Please move %post, %postun and %posttrans sections after %clean.

* It should be better to separate every changelog entry with a blank line. It
would be much more readable.

* Changelog format is slightly wrong:

* Sat Nov 21 2009 Cedric OLIVIER <cedric.olivier at free.fr>  0-0.3.2255svn
                                                         ^^
There should be only one space.

* You must keep the package updated to the latest JOSM stable (2561 at the time
of writing).

* Please add CONTRIBUTION among %doc

* I still think that for josm it is not very useful to have a jar called
%{name}-%{version}.jar because it will be "josm-0" for a long time.
%{name}-snapshot-<svn_version>.jar as upstream does is better.


I still have to examine your patches and some other things.


Please follow this guide, otherwise you won't be sponsored:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Do especially informal reviews of other packages. This is a good way to
convincing a sponsor that you have the required knowledge to become a packager.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.