[Bug 551587] Review Request: java-gnome - Java GNOME bindings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551587





--- Comment #2 from Alexander Boström <abo at root.snowtree.se>  2009-12-31 08:24:27 EDT ---
Quoting https://bugzilla.redhat.com/show_bug.cgi?id=438452#c14 here:

> I'm also not sure whether to care that the gcc invocations don't use
> $RPM_OPT_FLAGS and that make doesn't use %{?_smp_mflags}.

I think optflags are used properly now.

> [-] If the project name and the commonly used JAR filename differ, a symbolic
> link with the usual name must also be provided.
> 
>     If I understand this guideline correctly, the jar file generated by
>     this package should be called java-gnome.jar, with gtk.jar as a
>     symbolic link.

It now installs java-gnome-4.0.14.jar and a bunch of symlinks.

> [?] Since this package builds with OpenJDK, I'm not sure about the status
> of the GCJ guidelines. Probably not applicable ...

java-gnome upstream has stopped supporting gcj.

> [-] There are conflicting guidelines about JNI -- on the one hand, it says
> that 

They're still confusing, but I'm following the definitions under "Guideline"
and ignoring what's under "Rationale".

Quoting https://bugzilla.redhat.com/show_bug.cgi?id=438452#c15 here:

> Calling any of the jars delivered by this rpm as java-gnome.jar would make
> little sense and confuse people.  

Yeah, I'm also hesitant about inventing a name java-gnome.jar that upstream
doesn't use, but I'm doing just that now anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.