[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470155





--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-02-01 09:35:06 EDT ---
Created an attachment (id=330550)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=330550)
python 2.6 patch (proposed)

For 1.0-4

* Dependency
-----------------------------------------------------------
$ grep 'import ' xword 
import pygtk
import gtk
import gtk.gdk
import gobject
    import gnomeprint
    import gnomeprint.ui
import pango
import sys
import time
import os, os.path
import md5
import pickle
import ConfigParser
-----------------------------------------------------------
  - It seems "Requires: pygtk2 gnome-python2-gnomeprint" is
    sufficient.

* Scriptlets
  - For desktop-file-install, now "--vendor=fedora" is not needed
    (guidelines changed):
   
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

  - "Requires: shared-mime-info" is not needed:
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo

* Some misc issue
-----------------------------------------------------------
%prep
....
mkdir mime
cp -p %SOURCE2 mime
-----------------------------------------------------------
  - What are these lines for?

-----------------------------------------------------------
gzip $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1
-----------------------------------------------------------
  - Not needed. rpmbuild itself gzip's this automatically.

* Macros in %changelog
  - In changelog, when you write macros please use %% instead
    of % to prevent macros from being expanded.

* Python warning
  - By the way now rawhide uses python 2.6 and xword
    causes some warnings:
------------------------------------------------------------
./xword:50: DeprecationWarning: the md5 module is deprecated; use hashlib
instead
  import md5
------------------------------------------------------------
    Would you check if the attached patch works for you?

Then I will wait for your another review request or
your pre-review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.