[Bug 483187] Review Request: kde-plasma-weather - Plasma applet for weather forecasts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483187





--- Comment #6 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-02-01 12:51:53 EDT ---
(In reply to comment #2)
> > * please make use of the %{name} macro.
> 
> What for? It's not like the name is going to change frequently. That's just
> useless use of macros which doesn't help anyone.
> 

I've been told in many reviews that %{name} should be used extensively, except
a couple places like the URL. Even now, since there's a possibility that the
package name may be changed, it might come handy.

(In reply to comment #3)
> Actually, I'll replace Version: 0.0 with a real version number, I just asked
> the upstream author what to use. I also asked him whether he prefers
> kde-plasma-weather or kde-plasma-weatherforecast.

alright. let's wait.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.