[Bug 483187] Review Request: kde-plasma-weather - Plasma applet for weather forecasts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483187


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review+




--- Comment #13 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-02-01 14:25:17 EDT ---
(In reply to comment #11)
> > side note: Another thing that I've been told many times to use in a very
> > specific unique way and that I couldn't find in the guidelines is
> > %defattr(-,root,root,-)
> 
> That one is because the files must be owned by root. Without this, they can be
> owned by some other user depending on how the RPM package is built.
> 
I was more considered about the "-"s. I don't know why
   %defattr(-,root,root)
or
   %defattr(0644,root,root,0755)
is "bad" (even for RPMs for which one doesn't need to assign exotic
permissions)


> > The image on the left-hand side of the applet does not look right. No matter
> > how the weather is, it shows me a large black Ø contained in a larger white
> > rectangle.
> 
> This is because the BBC reports the current weather conditions as N/A for
> several locations. Apparently they don't get reports of weather conditions,
> only temperature and wind. So we get a huge N/A icon. :-(
That's what I suspected. The weather in this s.hole where I reside is so cold
that BBC doesn't know how to picture it.


Anyways, the package is good to go now. (One last thing, just an idea to clear
possible confusions in the future): you can add to the description that this
plasmoid is planned to be included in KDE 4.3.)

-----------------------------------------------------
This package (kde-plasma-weather) is APPROVED by oget
-----------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.