[Bug 481071] Review Request: tex-musixtex - Sophisticated music typesetting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481071


Sarantis Paskalis <paskalis at di.uoa.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Sarantis Paskalis <paskalis at di.uoa.gr>  2009-02-02 04:01:12 EDT ---
(In reply to comment #4)

> > (You can reuse the variables MUSIXTEXDIR etc).
> I couldn't use them because rpmbuild fails when a %files entry doesn't start
> with "/".

News to me.  I guess this is because they are variables and not rpm macros and
in another section of the rpm spec.  You could walk around this by declaring
these variables as macros and using them as such, e.g.

%define musixtexdir %{_texmf_main}/tex/generic/%{texname}

and then using %{musixtexdir} instead of $MUSIXTEXDIR

The only reason I would insist on that is for consistency reasons, so you could
either:
a) drop the variables alltogether, or
b) change them to macros, so that you can re-use them at the %files section

I am ok with all the other issues, and this is a style issue, so this package
is 
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.